[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

[Gulfem Savrun Yeniceri via Phabricator via libcxx-commits]

gulfem added a comment.

We also started seeing errors in our `Fuchsia` source code.

  [91666/283659](64) CXX obj/src/lib/elfldltl/test/note-fuzzer.note-fuzzer.cc.o
  FAILED: obj/src/lib/elfldltl/test/note-fuzzer.note-fuzzer.cc.o
  ../../../recipe_cleanup/clangyvv4ambu/bin/clang++ -MD -MF obj/src/lib/elfldltl/test/note-fuzzer.note-fuzzer.cc.o.d -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -DND...
  In file included from ../../src/lib/elfldltl/test/note-fuzzer.cc:5:
  In file included from ../../src/lib/elfldltl/include/lib/elfldltl/fuzzer.h:12:
  In file included from ../../src/lib/elfldltl/include/lib/elfldltl/layout.h:11:
  ../../../recipe_cleanup/clangyvv4ambu/bin/../include/c++/v1/string_view:279:45: error: implicit instantiation of undefined template 'std::char_traits<std::byte>'
      static_assert((is_same<_CharT, typename traits_type::char_type>::value),
                                              ^
  ../../src/lib/elfldltl/include/lib/elfldltl/note.h:97:9: note: in instantiation of template class 'std::basic_string_view<std::byte>' requested here
    Bytes desc;
          ^
  ../../../recipe_cleanup/clangyvv4ambu/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is declared here
  struct _LIBCPP_TEMPLATE_VIS char_traits;

https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8796686452214900177/overview


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307