[libcxx-commits] [PATCH] D138460: [libcxxabi] Overhaul test_exception_storage.pass.cpp

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: libcxxabi/test/test_exception_storage.pass.cpp:19
 
-typedef __cxxabiv1::__cxa_eh_globals globals_t ;
+void* thread_code(void* parm) {
+  void* globals = __cxxabiv1::__cxa_get_globals();
----------------
static


================
Comment at: libcxxabi/test/test_exception_storage.pass.cpp:42
+  std::vector<void*> thread_globals(num_threads);
+  std::vector<std::__libcpp_thread_t> threads(num_threads);
+
----------------
Since `#include <thread>` is included, is there a reason to use `std::__libcpp_thread_t` instead of `std::thread`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138460/new/

https://reviews.llvm.org/D138460