[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

[Tom Honermann via Phabricator via libcxx-commits]

tahonermann added inline comments.


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.lazy.split/general.pass.cpp:36-42
+  constexpr BasicSmallString(std::basic_string_view<char> v) : buffer_(v.begin(), v.end()) {}
+#ifndef TEST_HAS_NO_WIDE_CHARACTERS
+  constexpr BasicSmallString(std::basic_string_view<wchar_t> v) : buffer_(v.begin(), v.end()) {}
+#endif
+  constexpr BasicSmallString(std::basic_string_view<char8_t> v) : buffer_(v.begin(), v.end()) {}
+  constexpr BasicSmallString(std::basic_string_view<char16_t> v) : buffer_(v.begin(), v.end()) {}
+  constexpr BasicSmallString(std::basic_string_view<char32_t> v) : buffer_(v.begin(), v.end()) {}
----------------
Is the intent really to support conversions from ranges of different character types? That seems odd and doesn't seem to be required by the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307