[libcxx-commits] [PATCH] D138195: [libc++] Fix __regex_word value when using newlib/picolibc

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 22 01:45:17 PST 2022


arichardson marked an inline comment as done.
arichardson added a comment.

In D138195#3941657 <https://reviews.llvm.org/D138195#3941657>, @ldionne wrote:

> Thanks for checking. I guess this is fine from an ABI standpoint, however I do have a problem with us making Newlib-related changes at all since it's not supported. @arichardson How did you come across this issue?

I was trying to build some C++ code for an embedded target and as part of that tried to build libc++ because I saw there was existing newlib code inside libc++. It had bitrotted a bit due to missing CI, but wasn't too difficult to get working. Looking forward to the CI proposed by @michaelplatings :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138195/new/

https://reviews.llvm.org/D138195



More information about the libcxx-commits mailing list