[libcxx-commits] [PATCH] D131425: [libc++] Remove workarounds for systems with tortuous include requirements

[Mikael Holmén via Phabricator via libcxx-commits]

uabelho added a comment.

We also see errors with this patch, compiling on a clean tree. First error:

  [1/29] Building CXX object libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o
  FAILED: libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o 
  /repo/uabelho/main-github/llvm/build-all-builtins/./bin/clang++ --target=x86_64-unknown-linux-gnu -DLIBCXX_BUILDING_LIBCXXABI -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS="" -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/repo/uabelho/main-github/libcxx/src -Iinclude/c++/v1 -I/repo/uabelho/main-github/libcxxabi/include -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3  -fPIC -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -fno-exceptions -std=c++20 -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/system_error.cpp.o -c /repo/uabelho/main-github/libcxx/src/system_error.cpp
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:218:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:218:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:219:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    wstreampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:219:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    wstreampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:221:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u8streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:221:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u8streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:223:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u16streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:223:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u16streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:224:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u32streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:548:
  In file included from include/c++/v1/__ios/fpos.h:14:
  include/c++/v1/iosfwd:224:14: error: reference to unresolved using declaration
  typedef fpos<mbstate_t>    u32streampos;
               ^
  include/c++/v1/__mbstate_t.h:40:1: note: using declaration annotated with 'using_if_exists' here
  using ::mbstate_t _LIBCPP_USING_IF_EXISTS;
  ^
  In file included from /repo/uabelho/main-github/libcxx/src/system_error.cpp:19:
  In file included from include/c++/v1/string:561:
  In file included from include/c++/v1/__string/char_traits.h:29:
  In file included from include/c++/v1/cwchar:107:
  In file included from include/c++/v1/cwctype:56:
  In file included from include/c++/v1/wctype.h:67:
  /usr/include/wctype.h:111:22: error: unknown type name 'wint_t'
  extern int iswalnum (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:117:22: error: unknown type name 'wint_t'
  extern int iswalpha (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:120:22: error: unknown type name 'wint_t'
  extern int iswcntrl (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:124:22: error: unknown type name 'wint_t'
  extern int iswdigit (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:128:22: error: unknown type name 'wint_t'
  extern int iswgraph (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:133:22: error: unknown type name 'wint_t'
  extern int iswlower (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:136:22: error: unknown type name 'wint_t'
  extern int iswprint (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:141:22: error: unknown type name 'wint_t'
  extern int iswpunct (wint_t __wc) __THROW;
                       ^
  /usr/include/wctype.h:146:22: error: unknown type name 'wint_t'
  extern int iswspace (wint_t __wc) __THROW;
                       ^
  fatal error: too many errors emitted, stopping now [-ferror-limit=]
  20 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131425/new/

https://reviews.llvm.org/D131425