[libcxx-commits] [PATCH] D138461: [libcxxabi] Always use thread_local for cxa_exception_storage

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 21 16:10:12 PST 2022


smeenai created this revision.
Herald added a project: All.
smeenai requested review of this revision.
Herald added a project: libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++abi.

This was previously guarded by HAS_THREAD_LOCAL, which was never set by
CMake and had to be specified manually. Android has been setting this to
solve https://github.com/android/ndk/issues/1200 [1], but every compiler
and platform libc++abi supports should have thread_local by now, so we
can just get rid of the fallback implementation and simplify things
significantly (including removing the now unused fallback calloc).

[1] https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138461

Files:
  libcxxabi/src/cxa_exception_storage.cpp
  libcxxabi/src/fallback_malloc.cpp
  libcxxabi/src/fallback_malloc.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138461.477021.patch
Type: text/x-patch
Size: 4483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221122/9c64920d/attachment.bin>


More information about the libcxx-commits mailing list