[libcxx-commits] [PATCH] D138460: [libcxxabi] Overhaul test_exception_storage.pass.cpp

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 21 16:07:50 PST 2022


smeenai created this revision.
Herald added a subscriber: mgrang.
Herald added a project: All.
smeenai requested review of this revision.
Herald added a project: libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++abi.

I'm making a change in this area, so update the test in preparation:

- Get rid of an unnecessary sleep.
- Avoid some unnecessary size_t casts.
- Spawn the number of hardware threads instead of 10.
- Error if `__cxa_get_globals` and `__cxa_get_globals_fast` return different values (we'd previously exit with a zero code).
- Since I'm changing so much anyway, reformat the file as well, to reduce noise in any future changes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138460

Files:
  libcxxabi/test/test_exception_storage.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138460.477020.patch
Type: text/x-patch
Size: 4020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221122/d68f819e/attachment.bin>


More information about the libcxx-commits mailing list