[libcxx-commits] [PATCH] D138052: [libc++][format] Fixes visit_format_arg.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 4 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/__format/format_arg.h:282-294
+  switch (__arg.__type_) {
+  case __format::__arg_t::__i128: {
+    typename __basic_format_arg_value<_Context>::__handle __h{__arg.__value_.__i128_};
+    return _VSTD::invoke(_VSTD::forward<_Visitor>(__vis), typename basic_format_arg<_Context>::handle{__h});
+  }
+
+  case __format::__arg_t::__u128: {
----------------
ldionne wrote:
> That would reduce duplication below?
I was considering something similar, but was doubting whether it would be a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138052/new/

https://reviews.llvm.org/D138052