[libcxx-commits] [PATCH] D137597: [lbc++] Implement the rest of P0600R1 (nodiscard in the library)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments applied and CI passing.



================
Comment at: libcxx/test/std/utilities/utility/mem.res/nodiscard.verify.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Can you please make this `// UNSUPPORTED: c++03, c++11, c++14, c++17` so that this is a conformance test without any extensions in it? Then, add another test in `libcxx/test/libcxx/ ....` that checks the extension in C++17 mode. This is nitpicky, but I would like to keep the test for the extension separate.


================
Comment at: libcxx/test/std/utilities/utility/mem.res/nodiscard.verify.cpp:12
+
+// check that functions are marked [[nodiscard]]
+
----------------
Please add the synopsis of the functions you're checking for nodiscardness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137597/new/

https://reviews.llvm.org/D137597