[libcxx-commits] [PATCH] D137501: [libc++][math.h][NFC] Refactor enable_ifs

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM pending CI.



================
Comment at: libcxx/include/math.h:319
 
-template <class _A1>
-inline _LIBCPP_HIDE_FROM_ABI typename std::enable_if<std::is_floating_point<_A1>::value, bool>::type
-signbit(_A1 __x) _NOEXCEPT {
+template <class _A1, std::__enable_if_t<std::is_floating_point<_A1>::value, int> = 0>
+inline _LIBCPP_HIDE_FROM_ABI bool signbit(_A1 __x) _NOEXCEPT {
----------------
I don't think that is valid in C++03, but maybe Clang accepts it as an extension. In all case, I'm OK if the CI's happy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137501/new/

https://reviews.llvm.org/D137501