[libcxx-commits] [PATCH] D138195: [libc++] Fix __regex_word value when using newlib/picolibc

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a subscriber: ldionne.
philnik added a comment.

LGTM, since everybody seems to be on the same page here. @ldionne do you agree with this?



================
Comment at: libcxx/docs/ReleaseNotes.rst:135-136
+  uint16_t since all values of ``ctype_base::mask`` are taken. This is technically an ABI break, but including
+  ``<regex> `` has triggered a ``static_assert`` failure since libc++ 14, so it is unlikely that this causes a
+  real ABI break for existing users.
+
----------------
It's still an ABI break, we just don't expect people to care.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138195/new/

https://reviews.llvm.org/D138195