[libcxx-commits] [PATCH] D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

Here are the benchmark results:

  ------------------------------------------------------------
  Benchmark                                old             new
  ------------------------------------------------------------
  BM_join_view_in_vectors/0           0.701 ns         3.47 ns
  BM_join_view_in_vectors/1            16.6 ns         3.75 ns
  BM_join_view_in_vectors/2            33.7 ns         5.66 ns
  BM_join_view_in_vectors/64           1052 ns          172 ns
  BM_join_view_in_vectors/512          8255 ns         1400 ns
  BM_join_view_in_vectors/1024        16603 ns         2858 ns
  BM_join_view_in_vectors/4000        64662 ns        12452 ns
  BM_join_view_in_vectors/4096        66348 ns        12795 ns
  BM_join_view_in_vectors/5500        89765 ns        17645 ns
  BM_join_view_in_vectors/64000     1234386 ns       617878 ns
  BM_join_view_in_vectors/65536     1269340 ns       600301 ns
  BM_join_view_in_vectors/70000     1343142 ns       684041 ns
  BM_join_view_out_vectors/0          0.699 ns        0.736 ns
  BM_join_view_out_vectors/1           16.1 ns         3.79 ns
  BM_join_view_out_vectors/2           31.6 ns         5.93 ns
  BM_join_view_out_vectors/64           999 ns          161 ns
  BM_join_view_out_vectors/512         7932 ns         1457 ns
  BM_join_view_out_vectors/1024       15976 ns         2920 ns
  BM_join_view_out_vectors/4000       62218 ns        13179 ns
  BM_join_view_out_vectors/4096       63710 ns        13419 ns
  BM_join_view_out_vectors/5500       85663 ns        18292 ns
  BM_join_view_out_vectors/64000    1207589 ns       559316 ns
  BM_join_view_out_vectors/65536    1242416 ns       590786 ns
  BM_join_view_out_vectors/70000    1257713 ns       683171 ns
  BM_join_view_deques/0                3.08 ns         16.1 ns
  BM_join_view_deques/1                92.9 ns         19.4 ns
  BM_join_view_deques/2                 195 ns         26.2 ns
  BM_join_view_deques/64               5703 ns          251 ns
  BM_join_view_deques/512             43109 ns         2188 ns
  BM_join_view_deques/1024            88938 ns         5401 ns
  BM_join_view_deques/4000           360749 ns        27811 ns
  BM_join_view_deques/4096           371800 ns        28080 ns
  BM_join_view_deques/5500           501057 ns        38059 ns
  BM_join_view_deques/64000        10414050 ns      2155094 ns
  BM_join_view_deques/65536        10813164 ns      2132998 ns
  BM_join_view_deques/70000        11620544 ns      2395421 ns


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138413/new/

https://reviews.llvm.org/D138413