[libcxx-commits] [PATCH] D138189: [libcxx] adds an include-what-you-use (IWYU) mapping file

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 20 16:53:58 PST 2022


cjdb added a comment.

In D138189#3938244 <https://reviews.llvm.org/D138189#3938244>, @ldionne wrote:

> Thanks!
>
> LGTM, but can you please undo the formatting-only changes in `libcxx/utils/generate_header_tests.py`? I don't want to block the review on this so I'm approving right away, but I'd like those to be undone and pursued in a separate patch (if at all -- IMO the previous formatting was fine).

Yeah, sorry about that: my browser autoformats on save and since there's no .pyformat yapf just does whatever. I'll fix it up!

Before submitting: is the clang-cl static CI job a concern?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138189/new/

https://reviews.llvm.org/D138189



More information about the libcxx-commits mailing list