[libcxx-commits] [PATCH] D137640: [libcxx] Implement P2467R1: Support exclusive mode for fstreams

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for the patch! This looks reasonable but I think we're missing coverage.



================
Comment at: libcxx/include/ios:61
     static constexpr openmode in;
+    static constexpr openmode noreplace;
     static constexpr openmode out;
----------------



================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/noreplace.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
This should be inside `fstream.cons/path.pass.cpp` instead.

And we're missing tests for the other places where this flag can now be used, like `basic_filebuf`, `basic_ofstream`, etc. Those tests should be added to their existing tests for constructors that take `openmode`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137640/new/

https://reviews.llvm.org/D137640