[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_append/push_back.pass.cpp:27
+  template <>
+  struct char_traits<VeryLarge> {
+    using char_type           = VeryLarge;
----------------
ldionne wrote:
> philnik wrote:
> > I'd rather avoid opening the `std` namespace and instead use `template<> struct std::char_traits<VeryLarge>`.
> I don't think that's valid in C++03. GCC gives an error and requires using `-fpermissive`.
Huh, interesting. Weird that clang doesn't even give you a warning for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307