[libcxx-commits] [PATCH] D138327: [libc++] Introduce a setting to remove fstream from the library

Sat Nov 19 08:46:42 PST 2022

ldionne added a comment.

In D138327#3939014 <https://reviews.llvm.org/D138327#3939014>, @philnik wrote:

> Why does this need it's own flag, and isn't just under `_LIBCPP_HAS_NO_FILESYSTEM`?

Because `_LIBCPP_HAS_NO_FILESYSTEM` has been used to control whether we ship `<filesystem>`, and is for example disabled by default on Windows. See the comment in `libcxx/CMakeLists.txt`.

Rolling this setting into `_LIBCPP_HAS_NO_FILESYSTEM` will need to wait for https://reviews.llvm.org/D134912 to land and then I'll have to make sure that no other users of `_LIBCPP_HAS_NO_FILESYSTEM` are broken by also disabling `fstream` in that configuration, which will require a bit more time. So I am pursuing both at the same time because I don't want to wait that long to get this configuration, but notice how I did not document this new flag (this is on purpose so that people don't start depending on it).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138327/new/

https://reviews.llvm.org/D138327