[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

Fri Nov 18 09:18:58 PST 2022

philnik added inline comments.

================
Comment at: libcxx/include/__string/char_traits.h:42
 template <class _CharT>
-struct _LIBCPP_TEMPLATE_VIS char_traits
+struct _LIBCPP_TEMPLATE_VIS char_traits;
+/*
----------------
We probably shouldn't mark it with a visibility macro if we never define it. If people care about it they can add their own visibility macros to any specializations.

================
Comment at: libcxx/include/__string/char_traits.h:55
+
+    static _LIBCPP_CONSTEXPR_SINCE_CXX17 void   assign(char_type&, const char_type&) _NOEXCEPT;
+    static _LIBCPP_CONSTEXPR bool               eq(char_type, char_type) _NOEXCEPT;
----------------
These don't have to be marked `constexpr` or `noexcept` for user-provided ones. It's probably also just noise for most people.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307