[libcxx-commits] [PATCH] D138189: [libcxx] adds an include-what-you-use (IWYU) mapping file

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks! I think I really like this. We could also potentially use this as a tool to aid our removal of transitive includes -- arguably, if we provide a tool to automatically fix people's code, it may become more reasonable to break people's code through transitive include removals a bit more eagerly. I'm not suggesting we do that for now, just mentioning it.



================
Comment at: libcxx/include/libcxx.imp:1
+[
+  { include: [ "<__bits>", "private", "<bits>", "public" ] },
----------------
This patch doesn't ship this file with the libc++ headers. Did you mean to do that?


================
Comment at: libcxx/utils/generate_iwyu_mapping.py:1
+#!/usr/bin/env python
+
----------------
Just to clarify, we will not need to change this script unless we add a new detail header at the top level (which should be rare), right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138189/new/

https://reviews.llvm.org/D138189