[libcxx-commits] [PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 15 09:19:33 PST 2022


ldionne created this revision.
ldionne added a reviewer: Mordante.
Herald added a subscriber: arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added projects: clang, libc++.
Herald added subscribers: libcxx-commits, cfe-commits.
Herald added a reviewer: libc++.

Per post-commit comments in https://reviews.llvm.org/D137759.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138042

Files:
  clang/foo
  libcxx/foo
  libcxx/utils/ci/buildkite-pipeline-clang.yml
  libcxx/utils/ci/generate-buildkite-pipeline


Index: libcxx/utils/ci/generate-buildkite-pipeline
===================================================================
--- libcxx/utils/ci/generate-buildkite-pipeline
+++ libcxx/utils/ci/generate-buildkite-pipeline
@@ -12,15 +12,9 @@
 #
 
 if git diff --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
-  LIBCXX_CHANGED=true
+  cat libcxx/utils/ci/buildkite-pipeline.yml
 fi
 
 if git diff --name-only HEAD~1 | grep -q -E "^clang/"; then
-  CLANG_CHANGED=true
-fi
-
-if [[ "${CLANG_CHANGED}" == "true" && "${LIBCXX_CHANGED}" != "true" ]]; then
   cat libcxx/utils/ci/buildkite-pipeline-clang.yml
-else
-  cat libcxx/utils/ci/buildkite-pipeline.yml
 fi
Index: libcxx/utils/ci/buildkite-pipeline-clang.yml
===================================================================
--- libcxx/utils/ci/buildkite-pipeline-clang.yml
+++ libcxx/utils/ci/buildkite-pipeline-clang.yml
@@ -80,7 +80,7 @@
           limit: 2
     timeout_in_minutes: 120
 
-  - label: "Modules"
+  - label: "Clang Modules"
     commands:
       - "buildkite-agent artifact download 'install/**' ."
       - "export CC=$(pwd)/install/bin/clang"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138042.475504.patch
Type: text/x-patch
Size: 1152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221115/5aca5887/attachment.bin>


More information about the libcxx-commits mailing list