[libcxx-commits] [PATCH] D137911: [libc++][format] Makes format_context copyable.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 15 08:41:29 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ a proper regression test for this issue.



================
Comment at: libcxx/include/__format/format_context.h:88-89
 
-  basic_format_context(const basic_format_context&) = delete;
-  basic_format_context& operator=(const basic_format_context&) = delete;
-
----------------
Can we add tests to make sure that it is copyable iff the output iterator is copyable (which means we should also ensure it's not copyable when the output iterator isn't).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137911/new/

https://reviews.llvm.org/D137911



More information about the libcxx-commits mailing list