[libcxx-commits] [PATCH] D136683: [libc++] Only include_next C library headers when they exist

Tue Nov 15 08:38:40 PST 2022

philnik added a comment.

In D136683#3927771 <https://reviews.llvm.org/D136683#3927771>, @ldionne wrote:

> In D136683#3882795 <https://reviews.llvm.org/D136683#3882795>, @philnik wrote:
>
>> In essence LGTM. As another PR, could we maybe add a minimal set of C headers that are required to build and test libc++ with `LIBCXX_ENABLE_LOCALIZATION=Off`, `LIBCXX_ENABLE_UNICODE=Off`, etc? That would allow us to track what we require the C implementation to provide and we can actually test against a minimal C library. If you think that's a good idea I'd be happy to work on that.
>
> Yes, I think that would make sense, but I think it's also a non-negligible amount of work. You're thinking about making that part of the test suite, right?

Yes, that would be the idea. My idea was to write custom headers and use the actual implementation from llvm-libc. I think that should be quite manageable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136683/new/

https://reviews.llvm.org/D136683