[libcxx-commits] [libcxx] 0389438 - [libc++] Add a libc++ CI pipeline specific to Clang changes

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2022-11-11T14:43:22-10:00
New Revision: 038943834723e8569341bf62ff2d3b1919c47736

URL: https://github.com/llvm/llvm-project/commit/038943834723e8569341bf62ff2d3b1919c47736
DIFF: https://github.com/llvm/llvm-project/commit/038943834723e8569341bf62ff2d3b1919c47736.diff

LOG: [libc++] Add a libc++ CI pipeline specific to Clang changes

This will ensure that Clang changes get tested against libc++.

Differential Revision: https://reviews.llvm.org/D137759

Added: 
    libcxx/utils/ci/buildkite-pipeline-clang.yml

Modified: 
    libcxx/utils/ci/buildkite-pipeline-premerge.sh
    libcxx/utils/ci/generate-buildkite-pipeline

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/ci/buildkite-pipeline-clang.yml b/libcxx/utils/ci/buildkite-pipeline-clang.yml
new file mode 100644
index 0000000000000..b8ad2c1130469
--- /dev/null
+++ b/libcxx/utils/ci/buildkite-pipeline-clang.yml
@@ -0,0 +1,103 @@
+#===----------------------------------------------------------------------===##
+#
+# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+#
+#===----------------------------------------------------------------------===##
+
+#
+# This file describes the various pre-commit CI bots used to test Clang against
+# libc++ under various configurations. Unlike the usual libc++ CI pipeline,
+# which aims to test libc++ itself, this pipeline aims to test Clang by
+# compiling libc++ and running its test suite against the just-built Clang,
+# in various configurations.
+#
+env:
+    LLVM_HEAD_VERSION: "16"
+steps:
+  - label: "Building clang"
+    commands:
+      - "mkdir install"
+      - "cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=install -DLLVM_ENABLE_PROJECTS=\"clang;compiler-rt\""
+      - "ninja -C build install-clang install-clang-resource-headers"
+      - "buildkite-agent artifact upload 'install/**/*'"
+    env:
+        CC: "clang-${LLVM_HEAD_VERSION}"
+        CXX: "clang++-${LLVM_HEAD_VERSION}"
+    agents:
+      queue: "libcxx-builders"
+      os: "linux"
+    retry:
+      automatic:
+        - exit_status: -1  # Agent was lost
+          limit: 2
+    timeout_in_minutes: 120
+
+  - wait
+
+  - label: "C++03"
+    commands:
+      - "buildkite-agent artifact download 'install/**' ."
+      - "export CC=$(pwd)/install/bin/clang"
+      - "export CXX=$(pwd)/install/bin/clang++"
+      - "chmod +x install/bin/clang install/bin/clang++"
+      - "libcxx/utils/ci/run-buildbot generic-cxx03"
+    artifact_paths:
+      - "**/test-results.xml"
+      - "**/crash_diagnostics/*"
+    env:
+        LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
+    agents:
+      queue: "libcxx-builders"
+      os: "linux"
+    retry:
+      automatic:
+        - exit_status: -1  # Agent was lost
+          limit: 2
+    timeout_in_minutes: 120
+
+  - label: "C++2b"
+    commands:
+      - "buildkite-agent artifact download 'install/**' ."
+      - "export CC=$(pwd)/install/bin/clang"
+      - "export CXX=$(pwd)/install/bin/clang++"
+      - "chmod +x install/bin/clang install/bin/clang++"
+      - "libcxx/utils/ci/run-buildbot generic-cxx2b"
+    artifact_paths:
+      - "**/test-results.xml"
+      - "**/crash_diagnostics/*"
+    env:
+        LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
+    agents:
+      queue: "libcxx-builders"
+      os: "linux"
+    retry:
+      automatic:
+        - exit_status: -1  # Agent was lost
+          limit: 2
+    timeout_in_minutes: 120
+
+  - label: "Modules"
+    commands:
+      - "buildkite-agent artifact download 'install/**' ."
+      - "export CC=$(pwd)/install/bin/clang"
+      - "export CXX=$(pwd)/install/bin/clang++"
+      - "chmod +x install/bin/clang install/bin/clang++"
+      - "libcxx/utils/ci/run-buildbot generic-modules"
+    artifact_paths:
+      - "**/test-results.xml"
+      - "**/crash_diagnostics/*"
+    env:
+        LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
+        CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
+    agents:
+      queue: "libcxx-builders"
+      os: "linux"
+    retry:
+      automatic:
+        - exit_status: -1  # Agent was lost
+          limit: 2
+    timeout_in_minutes: 120

diff  --git a/libcxx/utils/ci/buildkite-pipeline-premerge.sh b/libcxx/utils/ci/buildkite-pipeline-premerge.sh
index 3f1d44c7430bd..d5273a03ea0b2 100755
--- a/libcxx/utils/ci/buildkite-pipeline-premerge.sh
+++ b/libcxx/utils/ci/buildkite-pipeline-premerge.sh
@@ -15,10 +15,8 @@
 # Invoked by CI on pre-merge check for a commit.
 #
 
-DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
-
-if ! git 
diff  --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
-  # libcxx/, libcxxabi/, libunwind/, runtimes/ or cmake/ are not affected
+if ! git 
diff  --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/|^clang/"; then
+  # libcxx/, libcxxabi/, libunwind/, runtimes/, cmake/ or clang/ are not affected
   exit 0
 fi
 

diff  --git a/libcxx/utils/ci/generate-buildkite-pipeline b/libcxx/utils/ci/generate-buildkite-pipeline
index 5910a927177ca..a917440bd3e9d 100755
--- a/libcxx/utils/ci/generate-buildkite-pipeline
+++ b/libcxx/utils/ci/generate-buildkite-pipeline
@@ -7,4 +7,12 @@
 #
 #===----------------------------------------------------------------------===##
 
-cat libcxx/utils/ci/buildkite-pipeline.yml
+#
+# This script generates the appropriate libc++ CI pipeline based on which project(s) were changed.
+#
+
+if git 
diff  --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
+  cat libcxx/utils/ci/buildkite-pipeline.yml
+elif git 
diff  --name-only HEAD~1 | grep -q -E "^clang/"; then
+  cat libcxx/utils/ci/buildkite-pipeline-clang.yml
+fi