[libcxx-commits] [PATCH] D137500: [libc++][math.h] Remove some code duplication

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 10 08:46:45 PST 2022


mstorsjo added a comment.

No specific opinion on this from my side - if it works for all clang-cl and mingw configs in CI, it's most probably fine with me. But CI seems to have not run correctly - it seems to have run before the parent patch was set up, so it failed to apply the patch. Rerunning it, now that the parent relationship is set up already, should hopefully make it apply it correctly and run the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137500/new/

https://reviews.llvm.org/D137500



More information about the libcxx-commits mailing list