[libcxx-commits] [PATCH] D137637: [libc++] Implement P2446R2 (views::as_rvalue)

[Hui via Phabricator via libcxx-commits]

huixie90 added inline comments.


================
Comment at: libcxx/include/__ranges/as_rvalue_view.h:51
+  {
+    return move_iterator(ranges::begin(__base_));
+  }
----------------
might be worth testing that if underlying iterator is already a move_iterator, this is calling the move constructor of `move_iterator` instead of creating a move_iterator<move_iterator<It>>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137637/new/

https://reviews.llvm.org/D137637