[libcxx-commits] [PATCH] D135248: [libc++] implement move_iterator<T*> should be a random access iterator

Shivam Rajput via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 8 01:48:09 PST 2022


phyBrackets marked 3 inline comments as done.
phyBrackets added inline comments.


================
Comment at: libcxx/include/__iterator/move_iterator.h:76
+#endif // _LIBCPP_STD_VER > 17
+template<class _It2> friend class move_iterator;
+
----------------
EricWF wrote:
> Why did this stuff get moved?
`__get_iterator_concept` and ` _Iter __current_`  both of them are the private members, so I thought we can place them together. but yeah i guess it's fine to place separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135248/new/

https://reviews.llvm.org/D135248



More information about the libcxx-commits mailing list