[libcxx-commits] [PATCH] D137283: [libc++] Granularize <concept> includes

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 7 09:06:25 PST 2022


Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/transitive_includes/cxx20.csv:666
 ranges compare
-ranges concepts
 ranges cstddef
----------------
philnik wrote:
> Mordante wrote:
> > unlike format, ranges is considered stable so we shouldn't remove this include here.
> ranges wasn't stable in LLVM 15, so I think we can still consider it experimental until the LLVM 16 release branch.
Ah I thought we manged to get that stable in time, then I agree we can remove them.


================
Comment at: libcxx/test/libcxx/transitive_includes/cxx2b.csv:3
 algorithm climits
-algorithm concepts
 algorithm cstddef
----------------
philnik wrote:
> Mordante wrote:
> > I think this removal isn't part of the release notes yet. Can you verify and add this header if needed.
> `<concepts>` is already in the list.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137283/new/

https://reviews.llvm.org/D137283



More information about the libcxx-commits mailing list