[libcxx-commits] [PATCH] D137499: [libc++][math.h] Remove __libcpp_<func> functions and instead call builtins directly

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 7 08:59:02 PST 2022


Mordante added a comment.

In general a nice cleanup, but I have a question.



================
Comment at: libcxx/include/math.h:532
-_LIBCPP_HIDE_FROM_ABI bool __libcpp_isgreater(_A1 __x, _A2 __y) _NOEXCEPT {
-  return isgreater(__x, __y);
-}
----------------
This one and the next ones didn't call a `__builtin`. Does this work on all supported platforms?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137499/new/

https://reviews.llvm.org/D137499



More information about the libcxx-commits mailing list