[libcxx-commits] [PATCH] D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 6 14:42:43 PST 2022


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Stop being clever in tests. These changes add a substantial cognitive load to any person who's trying to read them for the first time and understand what they do.

This code duplication doesn't cost us anything, but it gives us a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136908/new/

https://reviews.llvm.org/D136908



More information about the libcxx-commits mailing list