[libcxx-commits] [PATCH] D137476: [libc++] Add utilites for instantiating functions with multiple types

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

I don't think the test suite is the place to get clever with code deduplication and template magic.

Readability is significantly more important than repeating yourself. Tests need to be correct upon inspection, because we don't have tests for our tests.
Also I imagine this significantly borks any diagnostics you might get when the test fails.

Tests are not the place to be clever.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137476/new/

https://reviews.llvm.org/D137476