[libcxx-commits] [PATCH] D137451: [CMake] Use LLVM_TARGET_TRIPLE in runtimes

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM. I didn't realize the `LLVM_TARGET_TRIPLE` variable already existed and you were just making use of it in more places earlier.



================
Comment at: runtimes/CMakeLists.txt:156
 get_host_triple(LLVM_HOST_TRIPLE)
-set(LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_HOST_TRIPLE}" CACHE STRING
-  "Default target for which the runtimes will be built.")
+set(LLVM_TARGET_TRIPLE "${LLVM_HOST_TRIPLE}" CACHE STRING
+  "Target for which the runtimes will be built.")
----------------
Should we error if this isn't set, instead of defaulting to the host triple? All call sites from the runtimes build should be setting a value, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451