[libcxx-commits] [PATCH] D137451: [CMake] Use LLVM_TARGET_TRIPLE in runtimes

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 4 12:07:46 PDT 2022


smeenai added inline comments.


================
Comment at: runtimes/CMakeLists.txt:156
 get_host_triple(LLVM_HOST_TRIPLE)
 set(LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_HOST_TRIPLE}" CACHE STRING
   "Default target for which the runtimes will be built.")
----------------
We were previously setting `LLVM_DEFAULT_TARGET_TRIPLE` as part of our configure, so this CACHE setting would never take effect. We'll now set it to the host triple, which seems potentially undesirable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451



More information about the libcxx-commits mailing list