[libcxx-commits] [PATCH] D137338: Fix dupe word typos

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added a comment.

Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead.

As others said, appreciate the effort but the review process doesn't scale well to so many changes in one patch.



================
Comment at: lldb/include/lldb/Target/Process.h:1204
   /// platform that might itself be running natively, but have different
-  /// heuristics for figuring out which OS is is emulating.
+  /// heuristics for figuring out which OS is emulating.
   ///
----------------
This should be "which OS it is emulating".


================
Comment at: lldb/source/Symbol/LineTable.cpp:92
     // after the prologue.
-    // Instead of it it is issuing a line table entry for the first instruction
+    // Instead of it is issuing a line table entry for the first instruction
     // of the prologue and one for the first instruction after the prologue. If
----------------
This should be "Instead it is issuing".


================
Comment at: lldb/source/Target/RegisterContextUnwind.cpp:701
   // can have arbitrary number of frames with the same CFA, but more then 2 is
-  // very very unlikely)
 
----------------
This one is intended. It's not very scientific but hey, it's getting the point across.


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1045
   auto type_cstr = type_obj.GetDisplayTypeName();
-  // If we have a type with many many children, we would like to be able to
   // give a hint to the IDE that the type has indexed children so that the
----------------
This one is intended. Given the context of batching work, it's making the point for very large amounts of children.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137338/new/

https://reviews.llvm.org/D137338