[libcxx-commits] [PATCH] D137025: [libc++] inline more functions into basic_string

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 3 09:34:57 PDT 2022


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Disregard me. They were all marked inline already.

Though I must say, I prefer out-of-line definitions for big classes because it makes it easier to inspect the class and see we provide the correct declarations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137025/new/

https://reviews.llvm.org/D137025



More information about the libcxx-commits mailing list