[libcxx-commits] [PATCH] D136393: [libc++][math.h] Use builtins for all the functions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a subscriber: daltenty.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but please ping me if you need major changes to make the CI pass.



================
Comment at: libcxx/include/math.h:686
+#ifdef _AIX
+  return ::ldexpl(__x, __e);
+#else
----------------
Is there a reason why this builtin doesn't work correctly on AIX?

@daltenty @xingxue Can you get someone to fix this? When we try to make those `constexpr`, things could start failing pretty badly on AIX if we're not using builtins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136393/new/

https://reviews.llvm.org/D136393