[libcxx-commits] [PATCH] D135781: [libc++] Assume that builtins for math.h functions are available

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/math.h:286
 float          tgammaf(float x);
 long double    tgammal(long double x);
 
----------------
Can you try to:

1. Reformat the existing code in a separate patch
2. Make your change without packing the ifdefs
3. Then pack the ifdefs as a different patch

If that doesn't make the diff any better, nvm we'll review as-is, but I find it tricky to validate in the current state of the diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135781/new/

https://reviews.llvm.org/D135781