[libcxx-commits] [PATCH] D132061: [libc++] static_assert preconditions in vector

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D132061#3888778 <https://reviews.llvm.org/D132061#3888778>, @ldionne wrote:

> Actually, I'd like to see what the impact of this change is (given that our own tests seem to be violating some of these requirements). We should do it, but I still want to see the impact before we land it, because that will inform our communication about it. Can you ping me once CI is passing and I'll try this on our internal code base as a guinea pig.

There was actually a bug in `__is_cpp17_emplace_constructible`. I've added a regression test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132061/new/

https://reviews.llvm.org/D132061