[libcxx-commits] [PATCH] D124516: [libc++] Implement `std::expected` P0323R12

[Hui via Phabricator via libcxx-commits]

huixie90 marked 10 inline comments as done.
huixie90 added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/expected/expected.expected/assert.arrow.pass.cpp:11
+// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
+// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx{{10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0|12.0}}
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
----------------
ldionne wrote:
> I don't think those are required. Can you try removing them and seeing if the CI fails?
> 
> If I'm not mistaken, that line would have been added to another test that you copy-pasted from because that other class had some back-deployment requirements. `expected` does not, because we decided not to put the exception class in the dylib.
It turns out that after removing this, the test does fail on the Apple systems

https://reviews.llvm.org/harbormaster/unit/view/5402162/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124516/new/

https://reviews.llvm.org/D124516