[libcxx-commits] [PATCH] D124516: [libc++] Implement `std::expected` P0323R12
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Nov 1 17:36:20 PDT 2022
EricWF added inline comments.
================
Comment at: libcxx/include/__expected/expected.h:222
+ : __has_val_(__other.__has_val_) {
+ if (__has_val_) {
+ std::construct_at(std::addressof(__val_), std::move(__other.__val_));
----------------
EricWF wrote:
> Shouldn't `other.__has_val_` be
Ignore me. I had a dumb thought, but forgot to delete the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124516/new/
https://reviews.llvm.org/D124516
More information about the libcxx-commits
mailing list