[libcxx-commits] [PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

Tue Nov 1 13:24:42 PDT 2022

mizvekov added a comment.

In D136533#3899628 <https://reviews.llvm.org/D136533#3899628>, @ldionne wrote:

> It might be a problem, but I would argue we should still do it after fixing any problematic cases. It seems like Clang's current behavior is broken, as it basically ignores the `[[deprecated]]` attribute on aliases?

Yep. I expect we will find lots of similar cases.

> If so, then perhaps it would make sense to wait a few months before we merge this, perhaps at least until LLVM 16 is out so there's an officially-released version of libc++ that doesn't break with this change. But I think that's a decision for the Clang folks to make, not libc++.

I would be completely fine with doing a targeted workaround for libc++. The longer we don't patch this and warn on new code, the less likely we will ever be able to get rid of the bug. The problem is that we don't fully understand what is going on here, and how narrow this workaround can be.
I will try to take a look at this again, and see if I can reduce it to something that makes either libc++ or clang seem unreasonable. But I'll be off to the devmtg soon, and then take some vacations, so it will take a while.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136533/new/

https://reviews.llvm.org/D136533