[libcxx-commits] [PATCH] D136538: [libc++] Add test for checking progress on P0533R9

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D136538#3899436 <https://reviews.llvm.org/D136538#3899436>, @ldionne wrote:

> Thanks for the contribution. However, this looks a bit unusual to me. @philnik I think this should really be under `libcxx/test/std` since we are testing standard conformance. We would comment out tests for functions that we don't implement constexpr for yet, and uncomment them as we go. This is what we've done a bunch in e.g. `ranges`.

I'd consider this test to be a bit different. Here we essentially check what the compiler has implemented. We don't have to do anything special in the implementation, we just have to add `constexpr` to the functions. My plan was to add tests as we mark the functions `constexpr`, since our current `cmath` tests are really lacking. It currently also differs massively between the compilers what we can actually make `constexpr`, which isn't normally the case AFAIK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136538/new/

https://reviews.llvm.org/D136538