[libcxx-commits] [PATCH] D134036: [libc++][format] Implements string escaping.

[Erich Keane via Phabricator via libcxx-commits]

erichkeane added a comment.

In D134036#3898320 <https://reviews.llvm.org/D134036#3898320>, @ChuanqiXu wrote:

> In D134036#3887182 <https://reviews.llvm.org/D134036#3887182>, @ChuanqiXu wrote:
>
>> In D134036#3885470 <https://reviews.llvm.org/D134036#3885470>, @erichkeane wrote:
>>
>>> In D134036#3884982 <https://reviews.llvm.org/D134036#3884982>, @ChuanqiXu wrote:
>>>
>>>> @erichkeane I reproduced it but I don't have enough time to look at it actually today.
>>>
>>> Whew, at least I'm not the only one having this problem :D  The build-bots for libcxx never caught it, so I was afraid it was a problem with my setup.  I Tried to debug it for a while, and kept getting caught up in the module serialization/deserialization parts, and got lost :/
>>
>> I'm not sure if we can fix it quickly (I have too many TODOs). It looks like we need require the build-bots for libcxx to get some new setups.
>
> I filed an issue for it to make it easier to track: https://github.com/llvm/llvm-project/issues/58716

Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134036/new/

https://reviews.llvm.org/D134036