[libcxx-commits] [PATCH] D126738: [libc++][NFC] Mark the definition of ~basic_ios::basic_ios() as inline

[Alan Zhao via Phabricator via libcxx-commits]

ayzhao created this revision.
Herald added a project: All.
ayzhao requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is causing ODR violations in Chrome that is preventing it from
being built with libc++ debug symbols and ThinLTO[0].

[0]: https://crbug.com/1327706#c13


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126738

Files:
  libcxx/include/ios


Index: libcxx/include/ios
===================================================================
--- libcxx/include/ios
+++ libcxx/include/ios
@@ -695,7 +695,7 @@
 }
 
 template <class _CharT, class _Traits>
-basic_ios<_CharT, _Traits>::~basic_ios()
+inline basic_ios<_CharT, _Traits>::~basic_ios()
 {
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126738.433251.patch
Type: text/x-patch
Size: 304 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220601/ceb3f718/attachment-0001.bin>