[libcxx-commits] [PATCH] D125745: [libc++] Removes _LIBCPP_AVAILABILITY_TO_CHARS.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 31 10:06:14 PDT 2022


Mordante added a comment.

In D125745#3547648 <https://reviews.llvm.org/D125745#3547648>, @ldionne wrote:

> In D125745#3519531 <https://reviews.llvm.org/D125745#3519531>, @Mordante wrote:
>
>> Seems backdeployment fails so it seems we need to keep the availability macros.
>
> It looks to me like the only failure is an `XPASS` in `libcxx/test/std/utilities/charconv/charconv.from.chars/integral.roundtrip.pass.cpp`, where you seem to have forgotten to remove the `XFAIL` line. I think this patch should be revived!

Thanks good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125745/new/

https://reviews.llvm.org/D125745



More information about the libcxx-commits mailing list