[libcxx-commits] [PATCH] D125813: [libc++] Removes __cpp_lib_monadic_optional.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/optional:96
     template <class U = T>
-      constexpr EXPLICIT optional(U &&);
+      constexpr explicit optional(U &&);
     template <class U>
----------------
ldionne wrote:
> Those are conditionally explicit, so we should either use `EXPLICIT` or `explicit(see-below)` to show that they are not just `explicit`.
I think `explicit(see-below)` is the way to go here. I never would have guessed that `EXPLICIT` says that the `explicit` is conditional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125813/new/

https://reviews.llvm.org/D125813