[libcxx-commits] [PATCH] D126666: [libc++][CI] Updates Docker image.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

If we can't install LLVM 12 with `jammy`, we might have to wait until we branch for LLVM 15 (in a couple of months) before we can land this. Once we branch LLVM 15, our latest-2 will become LLVM 13, which should work with `jammy`.



================
Comment at: libcxx/utils/ci/Dockerfile:58
 # Install Clang <latest>, <latest-1> and ToT, which are the ones we support.
 # We also install <latest-2> to allow smooth CI transitions around release points.
+# TODO enable LVM_LATEST_VERSION - 2 after changing to version 15
----------------
I think this comment should be reworded to something like:

```
# We also install <latest-2> because we need to support the "latest-1" of the current release branch,
# which is effectively the <latest-2> of the tip-of-trunk LLVM. For example, after branching LLVM 14
# but before branching LLVM 15, we still need to have Clang 12 in this Docker image because the LLVM
# 14 release branch CI uses it. The tip-of-trunk CI will never use Clang 12, though.
```


================
Comment at: libcxx/utils/ci/Dockerfile:64
 RUN wget https://apt.llvm.org/llvm.sh -O /tmp/llvm.sh
-RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 2)) # for CI transitions
+#RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 2)) # for CI transitions
 RUN bash /tmp/llvm.sh $(($LLVM_LATEST_VERSION - 1)) # previous release
----------------
As explained above, the problem with removing this line as-is is that it's going to break CI on `release/14.x`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126666/new/

https://reviews.llvm.org/D126666