[libcxx-commits] [PATCH] D126621: [libc++] Fix typo in comment at __optional_storage_base

[Will Hawkins via Phabricator via libcxx-commits]

hawkinsw updated this revision to Diff 432828.
hawkinsw added a comment.

Updating after excellent feedback from @jloser.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126621/new/

https://reviews.llvm.org/D126621

Files:
  libcxx/include/optional


Index: libcxx/include/optional
===================================================================
--- libcxx/include/optional
+++ libcxx/include/optional
@@ -393,9 +393,9 @@
     }
 };
 
-// optional<T&> is currently required ill-formed, however it may to be in the
-// future. For this reason it has already been implemented to ensure we can
-// make the change in an ABI compatible manner.
+// optional<T&> is currently required to be ill-formed. However it may
+// be allowed in the future. For this reason, it has already been implemented
+// to ensure we can make the change in an ABI-compatible manner.
 template <class _Tp>
 struct __optional_storage_base<_Tp, true>
 {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126621.432828.patch
Type: text/x-patch
Size: 678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220530/8fe5705f/attachment.bin>