[libcxx-commits] [PATCH] D126621: [libc++] Fix typo in comment at __optional_storage_base

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun May 29 20:05:25 PDT 2022


jloser added inline comments.


================
Comment at: libcxx/include/optional:396
 
-// optional<T&> is currently required ill-formed, however it may to be in the
+// optional<T&> is currently required to be ill-formed, however it may be in the
 // future. For this reason it has already been implemented to ensure we can
----------------
philnik wrote:
> This sentence still doesn't make any sense. I think there is a "not" missing somewhere.
I'd be OK with something like this instead - what do you think?



> // optional<T&> is currently required to be ill-formed. However, it may be allowed in the
> // future. For this reason, it has already been implemented to ensure we can make the change in an ABI-compatible manner.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126621/new/

https://reviews.llvm.org/D126621



More information about the libcxx-commits mailing list