[libcxx-commits] [libcxx] 7f1e048 - [libc++][test] Remove Clang <= 3.7 workaround in is_default_constructible test

[Joe Loser via libcxx-commits]

Author: Joe Loser
Date: 2022-05-29T11:57:06-06:00
New Revision: 7f1e048041f5df3fd9d799cf13f20d5bce5967e1

URL: https://github.com/llvm/llvm-project/commit/7f1e048041f5df3fd9d799cf13f20d5bce5967e1
DIFF: https://github.com/llvm/llvm-project/commit/7f1e048041f5df3fd9d799cf13f20d5bce5967e1.diff

LOG: [libc++][test] Remove Clang <= 3.7 workaround in is_default_constructible test

Clang 3.7 and below is not actively used or supported in the test suite now, so
remove the workaround in the test.

Differential Revision: https://reviews.llvm.org/D126603

Added: 
    

Modified: 
    libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
index ce2ec95618e5f..72cd97e7a32d3 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
@@ -106,21 +106,11 @@ int main(int, char**)
 #if TEST_STD_VER >= 11
     test_is_not_default_constructible<B>();
     test_is_not_default_constructible<int&&>();
-
-// TODO: Remove this workaround once Clang <= 3.7 are no longer used regularly.
-// In those compiler versions the __is_constructible builtin gives the wrong
-// results for abominable function types.
-#if (defined(TEST_APPLE_CLANG_VER) && TEST_APPLE_CLANG_VER < 703) \
- || (defined(TEST_CLANG_VER) && TEST_CLANG_VER < 308)
-#define WORKAROUND_CLANG_BUG
-#endif
-#if !defined(WORKAROUND_CLANG_BUG)
     test_is_not_default_constructible<void()>();
     test_is_not_default_constructible<void() const> ();
     test_is_not_default_constructible<void() volatile> ();
     test_is_not_default_constructible<void() &> ();
     test_is_not_default_constructible<void() &&> ();
-#endif
 #endif
 
   return 0;