[libcxx-commits] [PATCH] D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay accepted this revision as: MaskRay.
MaskRay added a comment.
Herald added a subscriber: StephenFan.

I think it improves the robustness of the test. It'd be good to make tests at -O1 and above, not just -O0.

The test subject can mention `[test] ` to make it clear this is a non-code change.



================
Comment at: libunwind/test/libunwind_01.pass.cpp:167
   test_fpreg_get_set();
+  fprintf(stderr, "Success!\n");
   return 0;
----------------
The exit status is sufficient, no need for this log.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126611/new/

https://reviews.llvm.org/D126611