[libcxx-commits] [PATCH] D126603: [libc++][test] Remove Clang <= 3.7 workaround in is_default_constructible test

[Joe Loser via Phabricator via libcxx-commits]

jloser updated this revision to Diff 432790.
jloser added a comment.

Rebase to fix CI error with modules build being broken. If this passes CI, I'll land it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126603/new/

https://reviews.llvm.org/D126603

Files:
  libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp


Index: libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
===================================================================
--- libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
+++ libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_default_constructible.pass.cpp
@@ -106,21 +106,11 @@
 #if TEST_STD_VER >= 11
     test_is_not_default_constructible<B>();
     test_is_not_default_constructible<int&&>();
-
-// TODO: Remove this workaround once Clang <= 3.7 are no longer used regularly.
-// In those compiler versions the __is_constructible builtin gives the wrong
-// results for abominable function types.
-#if (defined(TEST_APPLE_CLANG_VER) && TEST_APPLE_CLANG_VER < 703) \
- || (defined(TEST_CLANG_VER) && TEST_CLANG_VER < 308)
-#define WORKAROUND_CLANG_BUG
-#endif
-#if !defined(WORKAROUND_CLANG_BUG)
     test_is_not_default_constructible<void()>();
     test_is_not_default_constructible<void() const> ();
     test_is_not_default_constructible<void() volatile> ();
     test_is_not_default_constructible<void() &> ();
     test_is_not_default_constructible<void() &&> ();
-#endif
 #endif
 
   return 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126603.432790.patch
Type: text/x-patch
Size: 1206 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220529/9343af30/attachment-0001.bin>